Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing custom exit line and toggling (ends with an arrow) hard crashes Mudlet #7198

Open
Balakay opened this issue Apr 5, 2024 · 9 comments
Assignees

Comments

@Balakay
Copy link

Balakay commented Apr 5, 2024

Brief summary of issue / Description of requested feature:

When you create a custom exit line - toggling the ends with an arrow checkbox will cause mudlet to abruptly crash and exit out

Steps to reproduce the issue / Reasons for adding feature:

  1. Create a custom exit line
  2. Open line properties
  3. Toggle (ends with an arrow:) checkbox
  4. Mudlet hard crashes

Error output / Expected result of feature

Extra information, such as the Mudlet version, operating system and ideas for how to solve / implement:

@Balakay
Copy link
Author

Balakay commented Apr 5, 2024

image

@vadi2 vadi2 added the high label Apr 5, 2024
@SlySven
Copy link
Member

SlySven commented Apr 6, 2024

I can't reproduce this on a build of the current development code on GNU/Linux with a Qt version of 5.18.8. What OS and release or PTB version are you getting it on?

@SlySven
Copy link
Member

SlySven commented Apr 6, 2024

image

HANG ON. What's with a custom exit line to a room with an id of -1? That shouldn't be possible as that means the destination room does not exist. Please select that line and delete it ASAP - no wonder things are going 💥❗

@vadi2
Copy link
Member

vadi2 commented Apr 6, 2024

It looks like our validation in this instance needs to be tougher :)

@Balakay
Copy link
Author

Balakay commented Apr 7, 2024

Oh.. Yeah - I see whats happening. I use the custom exit lines to point to rooms that the mapper can't recognize (because the exits are either present or not depending on attributes of a character. Rather than prevent that from happening - it would be beneficial to let a line just exist without any real "purpose" In this case the purpose is largely as a visual aide.

@Balakay
Copy link
Author

Balakay commented Apr 7, 2024

Well.. thats not 100% true - the destination DOES exist, but as a special exit (and not a normal connected exit)

image

@Balakay
Copy link
Author

Balakay commented Apr 7, 2024

it identifies the target destionation.. but isn't setting it in properties. Another couple images below for when i create the exit lines this way:

image

image

@Balakay
Copy link
Author

Balakay commented Apr 7, 2024

image

@SlySven
Copy link
Member

SlySven commented Apr 7, 2024

Oh! That is a bit naughty - I thought we didn't allow a "special" exit to have the same identifier as a "normal" exit - the problem is that the latter have preset keys for use in the containers that hold the details of custom exit lines and those containers are used for both special and normal exits!

💣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants