Skip to content
This repository has been archived by the owner on Jan 5, 2021. It is now read-only.

Musicoin Desktop Wallet 2.0 issues #285

Open
Varunram opened this issue Dec 5, 2018 · 0 comments
Open

Musicoin Desktop Wallet 2.0 issues #285

Varunram opened this issue Dec 5, 2018 · 0 comments

Comments

@Varunram
Copy link
Contributor

Varunram commented Dec 5, 2018

There are a number of issues that need to be resolved in order for us to push towards Musicoin Desktop Wallet 2.0:

#258: The new app must be in react for forwards compatibility. Using outdated packages as we do r right now is a security hazard and may possess unforeseen consequences.

#253 (and #214 by extension): Port conflict has been a long issue, so we need to start the wallet on a new port if the default one is not available. In order for us to this, #254 must be modified since that's the only way the desktop wallet can modify params in flags.go. Other suggestions a re also welcome, since those would close both the referenced issues.

#157: We need to sign the windows binaries because we don't want the wallet to be marked as a virus. This is also a potential vector for malice as someone could buy a certificate, sign and pass on a malicious version as the real one. To avoid this, it is better if the fault one is signed by default.

#276: We need to have a tx history tab since we can get that stuff from the local gmc instance without having to rely on explorer for what we have on local (some stuff like archival data still can't be served from local and explorer lookups are okay for those)

Minor issues like #205, #262 would ver nice to solve, although they shouldn't affect the performance / UX of the wallet.

Other issues like the news section would be nice to have, but are not strictly a requirement for 2.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant