You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think that it would be an improvement with errors if we check the user's locked balance first and make sure it's more than the amount he's placing an order for because otherwise you get error from balance module with an unreadable error message, unless you know know what that error code meant.
Another thing that could be an improvement is to take an optional TransactionalBlockhere which will allow me to do something like depositing first and then adding limit order in the same transactional block.
I think each function should take an optional TransactionalBlock rather than returning a new one as it'll help to chain other things together i.e. making things composable.
Hey, thanks for the feedback! We will take care of things on the Move side, but feel free to create a PR on the SDK with the improvement you mentioned.
I think that it would be an improvement with errors if we check the user's locked balance first and make sure it's more than the amount he's placing an order for because otherwise you get error from
balance
module with an unreadable error message, unless you know know what that error code meant.what do you think? happy to work on it if you think it would be an improvement in the sdk.
The text was updated successfully, but these errors were encountered: