Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guacamole upgrade script code optimization suggestion #267

Open
borross opened this issue Feb 6, 2024 · 1 comment
Open

Guacamole upgrade script code optimization suggestion #267

borross opened this issue Feb 6, 2024 · 1 comment

Comments

@borross
Copy link

borross commented Feb 6, 2024

Hello! Thanks for great scripts!
I want to share two mini code optimizations:

  1. Check latest version from official site (for example with using curl)
GUACVERSION=$(curl --silent https://guacamole.apache.org/ | grep 'Latest release' | awk '{print $4}' | cut -d "/" -f 3)
  1. Current version and new version comparison after the SERVER (# Set SERVER to be the preferred download server from the Apache CDN) variable, :
if [ $OLDVERSION = $GUACVERSION ]; then exit 0; fi

What do you think? Offer at your discretion :)

@itiligent
Copy link

Its a good suggestion, but in my experience, automatically allowing the guac version to install (or upgrade to ) may introduce some new complications.
This is becasue from Guac version to version, there have been other necessary changes required to the install script routines so as to support either the evolving Linux OS distros, or also to attend to various bugs that are specific to a particular Guac version and so on.

In my guacamole installer repo I check for any MySQL schema changes and then test both install and upgrade script actions before incremeting scripts to a newer version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants