Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate backend services and release automation to node 20 LTS version #1228

Closed
joswig opened this issue Nov 2, 2023 · 3 comments · Fixed by #1399
Closed

Migrate backend services and release automation to node 20 LTS version #1228

joswig opened this issue Nov 2, 2023 · 3 comments · Fixed by #1399
Assignees
@skovati
Labels
build Changes that affect the build system or external dependencies clipper-launch feature A new feature or feature request
Milestone
FY24 Q3 - Ad Hoc ...

Comments

@joswig
Copy link
Collaborator

joswig commented Nov 2, 2023 •
edited

Currently our release automation fails with node 20

We've pinned the release to node 18 in the interim, and we can move forward to 20, 22, etc once the build issue is corrected
@joswig joswig added the feature A new feature or feature request label Nov 2, 2023
@skovati skovati self-assigned this Nov 8, 2023
@joswig
Copy link
Collaborator Author

joswig commented Feb 5, 2024

Looks like this ts-node bug is part of the problem TypeStrong/ts-node#2094

@joswig joswig added the build Changes that affect the build system or external dependencies label Feb 5, 2024
@dyst5422
Copy link
Contributor

dyst5422 commented Feb 5, 2024 •
edited

I'll add that a switch to using tsx as a node loader rather than ts-node should be considered as well. (It's been suggested in the thread @joswig linked above a number of times).

Anecdotally, I've been using tsx for all my projects the last ~year+ with great success.

@skovati skovati added this to the FY24 Q2 - Ad Hoc Improvements milestone Mar 21, 2024
@dandelany dandelany changed the title Migrate to node 20 LTS version Migrate backend services and release automation to node 20 LTS version Mar 28, 2024
@dandelany
Copy link
Collaborator

For reference, the release automation workflow upgrades may be similar to these changes made for our workflow on the aerie repo: #1339

@skovati skovati mentioned this issue Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skovati skovati

Labels
build Changes that affect the build system or external dependencies clipper-launch feature A new feature or feature request
Projects
Aerie
Status: Done
Milestone
FY24 Q3 - Ad Hoc Improvements
Development

Successfully merging a pull request may close this issue.

Update node to LTS (20) NASA-AMMOS/aerie
4 participants
@dandelany @joswig @dyst5422 @skovati