Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 8 support #3514

Closed
Svetomechc opened this issue May 29, 2019 · 20 comments
Closed

Angular 8 support #3514

Svetomechc opened this issue May 29, 2019 · 20 comments
Assignees

Comments

@Svetomechc
Copy link
Contributor

What problem does this feature solve?

Align the library with latest Angular release

What does the proposed API look like?

[Not applicable]

@vthinkxie
Copy link
Member

we will support angular 8 in next month

@ElderJames
Copy link

我升级了版本号,ng-zorro还是能跑起来。
不知道哪些地方会出兼容性问题?

@vthinkxie vthinkxie self-assigned this May 30, 2019
@kunl
Copy link

kunl commented May 30, 2019

@ElderJames ivy 打包失败

@ElderJames
Copy link

发现ssr方式打包异常

@litice-wen
Copy link

升级了ng8,普通打包能正常通过;
启用ivy时,打包失败

@hwangzhiming
Copy link

experimental support for Ivy, not yet ready for production

@krokofant
Copy link
Contributor

So besides the experimental Ivy support Angular 8 works well with NgZorro?

@ningjn
Copy link

ningjn commented Jun 5, 2019

升级后,打包正常,运行会报错,null值操作,没找到原因,感觉应该是这个组件的原因,退回去了

@vthinkxie
Copy link
Member

vthinkxie commented Jun 5, 2019

Hi, all
ng-zorro-antd@7.x is not fully tested with angular 8 yet.
we will support angular 8 in late June, but ng-zorro-antd 8.0 may not support ivy because there are still some ivy issues blocked now
you can track them below
angular/angular-cli#14594
angular/angular#30080
angular/angular#29361

@Svetomechc
Copy link
Contributor Author

Svetomechc commented Jun 5, 2019

@vthinkxie this is quite okay with me since Ivy is still experimental and breaks my app anyway 😄

@vthinkxie
Copy link
Member

vthinkxie commented Jun 22, 2019

We have released the 8.0.0-rc.0 version, anyone who has interest could test it now.
This version is not recommended to use in production env.

@krokofant
Copy link
Contributor

krokofant commented Jun 27, 2019

@vthinkxie It seems that the rc releases are out on npm but not tagged or released on GitHub 😕 Could they be added to GitHub like the old rc's?

@vthinkxie
Copy link
Member

vthinkxie commented Jun 28, 2019

@krokofant we will release stable version this week, and 8.0.0-rc.2 has been released yesterday.

Some APIs will be deprecated in 8.0.0, but the old ones will still be supported before version 9.0.0.
It means that you may get some warning under dev environment, but it is compatible between 7.x and 8.x version.

@vthinkxie
Copy link
Member

vthinkxie commented Jun 29, 2019

angular 8 supported
check the changelog here https://ng.ant.design/docs/changelog/en

@Svetomechc
Copy link
Contributor Author

@vthinkxie what is the ETA on 8.1.0?

@vthinkxie
Copy link
Member

@Svetomechc will release 8.0.2 today

@Svetomechc
Copy link
Contributor Author

Svetomechc commented Jul 3, 2019

@vthinkxie will it be targeting Angular 8.1.0? There are a lot of fixes there, especially Ivy.

@Svetomechc
Copy link
Contributor Author

Svetomechc commented Jul 18, 2019

About Ivy:

@vthinkxie @hsuanxyz
angular/angular-cli#14594 seems to be fixed now
angular/angular#29361 can be worked around angular/angular#29361 (comment)
angular/angular#30080 is the only real showstopper now I guess

P.S. On an unrelated note, I think @angular/cdk version should be changed from ^8.0.0 to ~8.0.0 - ng-zorro-antd crashes at runtime on 8.1.x

@Svetomechc
Copy link
Contributor Author

Svetomechc commented Aug 2, 2019

@vthinkxie, is 8.2.0 supported? Lots and lots of minor visual glitches on production build (debug is fine though, guess TypeScript there is less strict - so my guess the problem lies in TypeScript 3.5).

@wzhudev
Copy link
Member

wzhudev commented Aug 2, 2019

@Svetomechc We just upgraded to TypeScript 3.5.3 yesterday (UTC+8). Check #3913.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants