Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat request: support nzPlacement in nz-menu / nz-submenu #4743

Closed
ccppprogrammer opened this issue Jan 30, 2020 · 2 comments · Fixed by #7420
Closed

feat request: support nzPlacement in nz-menu / nz-submenu #4743

ccppprogrammer opened this issue Jan 30, 2020 · 2 comments · Fixed by #7420
Assignees
@wenqi73
Labels
Component: Menu
Milestone
backlog

Comments

@ccppprogrammer
Copy link

ccppprogrammer commented Jan 30, 2020 •
edited

What problem does this feature solve?

Currently you cannot create a menu with different placement options, similar to nz-dropdown.

Thus, if you put nz-submenu with nzMode="horizontal", which is located in nz-header, on the right side of the header, nz-submenu goes beyond the visible area.

Example screenshot of the current behavior:

What does the proposed API look like?

nz-submenu of nz-menu in nzMode="horizontal" should support nzPlacement directive with at least bottomLeft and bottomRight values or correctly place sumenu on the screen automatically depending on the current position.

Property Description Type Default
[nzPlacement] placement of pop menu 'bottomLeft' | 'bottomCenter' | 'bottomRight' | 'topLeft' | 'topCenter' | 'topRight' 'bottomLeft'
@ccppprogrammer ccppprogrammer reopened this Feb 1, 2020
@weekly-digest weekly-digest bot mentioned this issue Feb 2, 2020
Closed
@vthinkxie vthinkxie mentioned this issue Mar 30, 2020
Closed
@hsuanxyz hsuanxyz added this to the backlog milestone Oct 22, 2020
@hsuanxyz hsuanxyz assigned wenqi73 and unassigned vthinkxie Oct 22, 2020
@timothyBrake
Copy link

This doesn't seem to be implemented yet or is it? Any workaround?

@klerick
Copy link
Contributor

klerick commented Apr 7, 2022

+1

klerick pushed a commit to klerick/ng-zorro-antd that referenced this issue May 10, 2022
feat(module:menu): add support nzPlacement for nz-submenu
c1d9179 
Closes NG-ZORRO#4743
@klerick klerick mentioned this issue May 10, 2022
Merged
3 tasks
simplejason pushed a commit that referenced this issue Sep 26, 2022
@klerick
feat(module:menu): add support nzPlacement for nz-submenu (#7420)
b1223bd 
Closes #4743

Co-authored-by: Alexander Kharkovey <alexander.kharkovey@nordigy.ru>
chenc041 pushed a commit to chenc041/ng-zorro-antd that referenced this issue Dec 14, 2022
@klerick @chenc041
feat(module:menu): add support nzPlacement for nz-submenu (NG-ZORRO#7420
837c02e 
)

Closes NG-ZORRO#4743

Co-authored-by: Alexander Kharkovey <alexander.kharkovey@nordigy.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wenqi73 wenqi73

Labels
Component: Menu
Projects
None yet
Milestone
backlog
Development

Successfully merging a pull request may close this issue.

feat(module:menu): add support nzPlacement for nz-submenu klerick/ng-zorro-antd
6 participants
@vthinkxie @klerick @ccppprogrammer @timothyBrake @hsuanxyz @wenqi73