Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:cascader): do not run change detections on non-handled keydown events #7060

Merged
merged 1 commit into from Dec 16, 2021

Conversation

arturovt
Copy link
Member

PR Checklist

PR Type

[x] Refactoring (no functional changes, no api changes)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@zorro-bot
Copy link

zorro-bot bot commented Nov 14, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #7060 (11595c3) into master (d45f0ab) will increase coverage by 0.01%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7060      +/-   ##
==========================================
+ Coverage   89.57%   89.58%   +0.01%     
==========================================
  Files         488      488              
  Lines       15821    15830       +9     
  Branches     2440     2439       -1     
==========================================
+ Hits        14171    14182      +11     
  Misses       1009     1009              
+ Partials      641      639       -2     
Impacted Files Coverage Δ
components/cascader/cascader.component.ts 94.76% <94.44%> (+0.14%) ⬆️
components/tabs/tab-nav-bar.component.ts 83.68% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d45f0ab...11595c3. Read the comment docs.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 9a37718 into NG-ZORRO:master Dec 16, 2021
@arturovt arturovt deleted the perf/cascader-reduce-cd branch December 16, 2021 15:12
qugemingzizhenmafan pushed a commit to qugemingzizhenmafan/ng-zorro-antd that referenced this pull request Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants