Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:popconfirm): missing arrow #7086

Merged

Conversation

chenc041
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Any default nz-popconfirm will not show the 'arrow' even though it is marked as the default action.

Issue Number: #7064

What is the new behavior?

When using nz-popconfirm it used to have the little 'arrow' on the edge of the popconfirm dialog box;

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Nov 29, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #7086 (58b10ef) into master (4f868e4) will decrease coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7086      +/-   ##
==========================================
- Coverage   89.92%   89.60%   -0.33%     
==========================================
  Files         481      488       +7     
  Lines       15380    15873     +493     
  Branches     2344     2584     +240     
==========================================
+ Hits        13831    14223     +392     
- Misses        929     1017      +88     
- Partials      620      633      +13     
Impacted Files Coverage Δ
components/popconfirm/popconfirm.ts 96.15% <ø> (-3.85%) ⬇️
.../table/src/table/table-virtual-scroll.directive.ts 25.00% <0.00%> (-25.00%) ⬇️
components/core/overlay/nz-connected-overlay.ts 85.71% <0.00%> (-14.29%) ⬇️
components/table/src/table/tr-measure.component.ts 86.95% <0.00%> (-13.05%) ⬇️
components/table/src/table/tbody.component.ts 88.88% <0.00%> (-11.12%) ⬇️
components/core/services/resize.ts 85.71% <0.00%> (-6.60%) ⬇️
components/core/config/config.service.ts 91.17% <0.00%> (-5.89%) ⬇️
components/steps/steps.component.ts 91.13% <0.00%> (-5.74%) ⬇️
components/core/tree/nz-tree-base-util.ts 84.37% <0.00%> (-5.63%) ⬇️
...ts/table/src/table/table-inner-scroll.component.ts 77.14% <0.00%> (-4.29%) ⬇️
... and 352 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f868e4...58b10ef. Read the comment docs.

@wzhudev
Copy link
Member

wzhudev commented Dec 13, 2021

Hi. Thanks for this PR. Could you please make the CI pass?

@chenc041
Copy link
Contributor Author

Hi. Thanks for this PR. Could you please make the CI pass?

ok, wait ~

@chenc041
Copy link
Contributor Author

Hi. Thanks for this PR. Could you please make the CI pass?

pass~

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 3f4a704 into NG-ZORRO:master Dec 16, 2021
qugemingzizhenmafan pushed a commit to qugemingzizhenmafan/ng-zorro-antd that referenced this pull request Dec 17, 2021
* fix(module:popconfirm): missing arrow

* chore:  trigger ci

* fix: lint error
@chenc041 chenc041 deleted the fix(modulepopconfirm)-missing-arrow branch June 7, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants