Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker,time-picker): disable autocomplete completely #7088

Merged
merged 1 commit into from Dec 16, 2021

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Nov 30, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Nov 30, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #7088 (a2913b0) into master (891a622) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7088      +/-   ##
==========================================
+ Coverage   89.59%   89.63%   +0.03%     
==========================================
  Files         488      488              
  Lines       15873    15873              
  Branches     2446     2446              
==========================================
+ Hits        14222    14227       +5     
+ Misses       1017     1014       -3     
+ Partials      634      632       -2     
Impacted Files Coverage Δ
components/date-picker/date-picker.component.ts 90.90% <ø> (ø)
components/time-picker/time-picker.component.ts 85.18% <ø> (ø)
components/time-picker/time-holder.ts 96.84% <0.00%> (+1.05%) ⬆️
components/tabs/tab-nav-bar.component.ts 85.81% <0.00%> (+1.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 891a622...a2913b0. Read the comment docs.

Copy link
Member

@wenqi73 wenqi73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenqi73 wenqi73 closed this Dec 13, 2021
@wenqi73 wenqi73 reopened this Dec 13, 2021
@simplejason simplejason merged commit bddc537 into NG-ZORRO:master Dec 16, 2021
qugemingzizhenmafan pushed a commit to qugemingzizhenmafan/ng-zorro-antd that referenced this pull request Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DatePicker和TimePicker组件内的input能加上autocomplete="off"或者能提供参数设定
3 participants