Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:carousel): do not run change detection on non-handled keydown events #7097

Merged
merged 1 commit into from Dec 17, 2021

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Dec 1, 2021

PR Checklist

PR Type

[x] Refactoring (no functional changes, no api changes)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@zorro-bot
Copy link

zorro-bot bot commented Dec 1, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #7097 (4324122) into master (d78a8d2) will decrease coverage by 0.00%.
The diff coverage is 88.23%.

❗ Current head 4324122 differs from pull request most recent head 6fb1f6a. Consider uploading reports for the commit 6fb1f6a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7097      +/-   ##
==========================================
- Coverage   89.63%   89.62%   -0.01%     
==========================================
  Files         488      488              
  Lines       15873    15879       +6     
  Branches     2446     2446              
==========================================
+ Hits        14227    14232       +5     
- Misses       1014     1015       +1     
  Partials      632      632              
Impacted Files Coverage Δ
components/carousel/carousel.component.ts 89.63% <88.23%> (+0.39%) ⬆️
components/time-picker/time-holder.ts 95.78% <0.00%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d78a8d2...6fb1f6a. Read the comment docs.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit ca3299e into NG-ZORRO:master Dec 17, 2021
@arturovt arturovt deleted the perf/carousel-keydown branch December 17, 2021 03:16
qugemingzizhenmafan pushed a commit to qugemingzizhenmafan/ng-zorro-antd that referenced this pull request Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants