Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:image): unsubscribe old src #7102

Merged
merged 1 commit into from Jan 14, 2022

Conversation

qugemingzizhenmafan
Copy link
Contributor

@qugemingzizhenmafan qugemingzizhenmafan commented Dec 3, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Dec 3, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #7102 (338f51c) into master (d9982e9) will increase coverage by 0.09%.
The diff coverage is 95.17%.

❗ Current head 338f51c differs from pull request most recent head 575d98a. Consider uploading reports for the commit 575d98a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7102      +/-   ##
==========================================
+ Coverage   89.63%   89.72%   +0.09%     
==========================================
  Files         488      488              
  Lines       15873    15937      +64     
  Branches     2584     2579       -5     
==========================================
+ Hits        14227    14299      +72     
+ Misses       1014     1006       -8     
  Partials      632      632              
Impacted Files Coverage Δ
components/menu/submenu.component.ts 98.93% <ø> (-0.02%) ⬇️
components/popconfirm/popconfirm.ts 96.15% <ø> (ø)
components/time-picker/time-picker.component.ts 85.18% <ø> (ø)
components/carousel/carousel.component.ts 89.63% <88.23%> (+0.39%) ⬆️
components/switch/switch.component.ts 96.20% <90.00%> (+0.68%) ⬆️
components/cascader/cascader.component.ts 94.76% <94.44%> (+0.14%) ⬆️
components/date-picker/date-picker.component.ts 90.87% <100.00%> (-0.04%) ⬇️
...mponents/date-picker/date-range-popup.component.ts 91.35% <100.00%> (+1.35%) ⬆️
components/icon/icon.directive.ts 95.58% <100.00%> (+0.42%) ⬆️
components/image/image.directive.ts 91.13% <100.00%> (+0.47%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9982e9...575d98a. Read the comment docs.

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants