Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:switch): reduce change detection cycles #7105

Merged
merged 1 commit into from Dec 17, 2021

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Dec 5, 2021

PR Checklist

PR Type

[x] Refactoring (no functional changes, no api changes)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@zorro-bot
Copy link

zorro-bot bot commented Dec 5, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 5, 2021

Codecov Report

Merging #7105 (5083fb1) into master (d9982e9) will decrease coverage by 0.01%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7105      +/-   ##
==========================================
- Coverage   89.63%   89.61%   -0.02%     
==========================================
  Files         488      488              
  Lines       15873    15885      +12     
  Branches     2584     2582       -2     
==========================================
+ Hits        14227    14236       +9     
- Misses       1014     1016       +2     
- Partials      632      633       +1     
Impacted Files Coverage Δ
components/switch/switch.component.ts 96.20% <90.00%> (+0.68%) ⬆️
components/core/util/text-measure.ts 89.47% <0.00%> (-1.76%) ⬇️
components/time-picker/time-holder.ts 95.78% <0.00%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9982e9...5083fb1. Read the comment docs.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 6d9b1ff into NG-ZORRO:master Dec 17, 2021
@arturovt arturovt deleted the perf/switch branch December 17, 2021 03:39
qugemingzizhenmafan pushed a commit to qugemingzizhenmafan/ng-zorro-antd that referenced this pull request Dec 17, 2021
@zhenzhenChange
Copy link

Why was this change not added to the changelog?

@simplejason
Copy link
Member

Why was this change not added to the changelog?

Is this PR causing any problems? If so, please submit an issue, and of course you are welcome to submit a PR to optimize :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants