Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:timeline): when the data clear, reset items #7109

Merged
merged 1 commit into from Dec 16, 2021

Conversation

to0simple
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Dec 6, 2021

This preview will be available after the AzureCI is passed.

@to0simple
Copy link
Contributor Author

#7030

@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #7109 (7001145) into master (d9982e9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7109      +/-   ##
==========================================
- Coverage   89.63%   89.61%   -0.02%     
==========================================
  Files         488      488              
  Lines       15873    15875       +2     
  Branches     2584     2584              
==========================================
- Hits        14227    14226       -1     
- Misses       1014     1015       +1     
- Partials      632      634       +2     
Impacted Files Coverage Δ
components/timeline/timeline.component.ts 98.14% <100.00%> (+0.07%) ⬆️
components/core/util/text-measure.ts 89.47% <0.00%> (-1.76%) ⬇️
components/time-picker/time-holder.ts 95.78% <0.00%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9982e9...7001145. Read the comment docs.

@wzhudev
Copy link
Member

wzhudev commented Dec 6, 2021

Hi. Thanks for this PR. Could you please add a test to ensure code coverage?

@to0simple
Copy link
Contributor Author

Hi. Thanks for this PR. Could you please add a test to ensure code coverage?

I've added a test.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 0ece612 into NG-ZORRO:master Dec 16, 2021
qugemingzizhenmafan pushed a commit to qugemingzizhenmafan/ng-zorro-antd that referenced this pull request Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants