Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:cdk): resolve leak #7139

Merged
merged 1 commit into from Jan 17, 2022

Conversation

arturovt
Copy link
Member

PR Checklist

PR Type

[x] Bugfix

@zorro-bot
Copy link

zorro-bot bot commented Dec 22, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #7139 (6f52021) into master (ab78821) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 6f52021 differs from pull request most recent head de79f7b. Consider uploading reports for the commit de79f7b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7139      +/-   ##
==========================================
- Coverage   89.75%   89.70%   -0.05%     
==========================================
  Files         488      488              
  Lines       15937    15945       +8     
  Branches     2579     2579              
==========================================
  Hits        14304    14304              
- Misses       1001     1007       +6     
- Partials      632      634       +2     
Impacted Files Coverage Δ
components/anchor/anchor.component.ts 97.11% <ø> (ø)
components/collapse/collapse-panel.component.ts 93.10% <ø> (ø)
components/drawer/drawer.component.ts 98.01% <ø> (ø)
components/form/form-control.component.ts 93.44% <ø> (ø)
components/layout/sider.component.ts 94.82% <ø> (ø)
components/transfer/transfer-list.component.ts 96.22% <ø> (ø)
components/transfer/transfer-search.component.ts 100.00% <ø> (ø)
components/cascader/cascader-li.component.ts 100.00% <100.00%> (ø)
components/cascader/cascader.component.ts 94.79% <100.00%> (+0.03%) ⬆️
components/skeleton/skeleton-element.component.ts 95.00% <100.00%> (+0.26%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab78821...de79f7b. Read the comment docs.

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz merged commit 2a93d05 into NG-ZORRO:master Jan 17, 2022
@arturovt arturovt deleted the fix/cdk-overflow-leak branch January 17, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants