Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:tree-view): do not run change detection on click events if the nz-tree-node-option is disabled or there are no nzClick listeners #7178

Merged

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Jan 2, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

[x] Refactoring (no functional changes, no api changes)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

…f the `nz-tree-node-option` is disabled or there are no `nzClick` listeners
@zorro-bot
Copy link

zorro-bot bot commented Jan 2, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 2, 2022

Codecov Report

Merging #7178 (bd8cb7f) into master (77db914) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7178   +/-   ##
=======================================
  Coverage   91.67%   91.67%           
=======================================
  Files         486      486           
  Lines       15868    15868           
  Branches     2587     2587           
=======================================
  Hits        14547    14547           
  Misses       1007     1007           
  Partials      314      314           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77db914...bd8cb7f. Read the comment docs.

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 0054f59 into NG-ZORRO:master Feb 18, 2022
@arturovt arturovt deleted the perf/tree-view-node-option-click branch February 19, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants