Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar collapse icon issue #7186

Closed
Vikramalakshman opened this issue Jan 4, 2022 · 1 comment · Fixed by #7188
Closed

Sidebar collapse icon issue #7186

Vikramalakshman opened this issue Jan 4, 2022 · 1 comment · Fixed by #7188
Assignees
@arturovt @wzhudev
Labels
🐛 Bug Component: Icon

Comments

@Vikramalakshman
Copy link

Vikramalakshman commented Jan 4, 2022 •
edited

SidebarICollapseIcon

Reproduction link

https://stackblitz.com/run

Steps to reproduce


1. Go to the official website: https://ng.ant.design/components/me![SidebarICollapseIcon](https://user-images.githubusercontent.com/73377984/148087472-1cd9103d-7d79-4b6e-8858-988049f89a91.PNG)
2. then just click once on the collapse icon and do not move the cursor and now the double icon issue could be noticable

What is expected?

Collapse icon should appear only once when it is clicked even after page reload

What is actually happening?

Sidebar collapse icon is appearing twice when it is clicked first time after reload

Environment Info
ng-zorro-antd 13.0.0
Browser Chrome

this double icon issue comes only once per page successful loading
but this issue is not happening in stackblitz
this bug is presented in (ng.ant.design) official page
@yangjunhan
Copy link
Contributor

@wendellhu95 I think this is related to the Icon Module and caused by the perf PR #7071 , which setSVGData method is running outside the Angular zone. Could you help take a look at it?

@hsuanxyz hsuanxyz assigned arturovt and unassigned vthinkxie Jan 5, 2022
wzhudev pushed a commit that referenced this issue Jan 5, 2022
fix(module:icon): fix old icon element not removed
052e8ee 
close #7186
@wzhudev wzhudev mentioned this issue Jan 5, 2022
Merged
3 tasks
simplejason pushed a commit that referenced this issue Jan 10, 2022
fix(module:icon): fix old icon element not removed (#7188)
67ac573 
* fix(module:icon): fix old icon element not removed

close #7186

* fix: fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arturovt arturovt

@wzhudev wzhudev

Labels
🐛 Bug Component: Icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(module:icon): fix old icon element not removed NG-ZORRO/ng-zorro-antd
6 participants
@vthinkxie @arturovt @wzhudev @hsuanxyz @yangjunhan @Vikramalakshman