Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:upload): fix the problem that the transformed file is lost #7206

Merged
merged 1 commit into from Mar 3, 2022
Merged

fix(module:upload): fix the problem that the transformed file is lost #7206

merged 1 commit into from Mar 3, 2022

Conversation

HyperLife1119
Copy link
Collaborator

@HyperLife1119 HyperLife1119 commented Jan 14, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

The transformed file will be ignored in subsequent pipeline operations.

What is the new behavior?

Transformed file are not ignored.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jan 14, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #7206 (3987d2b) into master (c177558) will increase coverage by 0.04%.
The diff coverage is 88.05%.

❗ Current head 3987d2b differs from pull request most recent head 13a53c7. Consider uploading reports for the commit 13a53c7 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7206      +/-   ##
==========================================
+ Coverage   91.67%   91.71%   +0.04%     
==========================================
  Files         486      486              
  Lines       15868    15926      +58     
  Branches     2587     2590       +3     
==========================================
+ Hits        14547    14607      +60     
+ Misses       1007     1004       -3     
- Partials      314      315       +1     
Impacted Files Coverage Δ
components/drawer/drawer.component.ts 98.51% <ø> (ø)
components/modal/modal.service.ts 95.91% <ø> (ø)
components/code-editor/code-editor.component.ts 16.00% <14.28%> (+0.29%) ⬆️
components/upload/upload-btn.component.ts 97.93% <50.00%> (-1.03%) ⬇️
components/core/services/breakpoint.ts 94.44% <66.66%> (-5.56%) ⬇️
...ts/auto-complete/autocomplete-trigger.directive.ts 98.84% <100.00%> (+0.01%) ⬆️
components/breadcrumb/breadcrumb-item.component.ts 100.00% <100.00%> (ø)
components/breadcrumb/breadcrumb.component.ts 98.38% <100.00%> (ø)
components/checkbox/checkbox.component.ts 98.63% <100.00%> (+0.19%) ⬆️
components/icon/icon.directive.ts 97.14% <100.00%> (+0.08%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c177558...13a53c7. Read the comment docs.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit b82d2f3 into NG-ZORRO:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants