Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:back-top): fix more reliable scrolling listener #7208

Merged
merged 1 commit into from Jan 17, 2022

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jan 15, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jan 15, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 15, 2022

Codecov Report

Merging #7208 (333e36a) into master (806f024) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 333e36a differs from pull request most recent head c4de1dc. Consider uploading reports for the commit c4de1dc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7208      +/-   ##
==========================================
- Coverage   91.73%   91.72%   -0.01%     
==========================================
  Files         486      486              
  Lines       15918    15918              
  Branches     2588     2588              
==========================================
- Hits        14602    14601       -1     
- Misses       1003     1004       +1     
  Partials      313      313              
Impacted Files Coverage Δ
components/back-top/back-top.component.ts 90.90% <ø> (ø)
components/core/util/text-measure.ts 92.10% <0.00%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 806f024...c4de1dc. Read the comment docs.

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz merged commit 3bcd343 into NG-ZORRO:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-back-top组件,用鼠标滚轮快速滚动到容器顶部,返回页面顶部的操作按钮未消失
2 participants