Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:input): incorrect background color in disabled state #7250

Merged
merged 3 commits into from Feb 25, 2022

Conversation

chenc041
Copy link
Contributor

@chenc041 chenc041 commented Feb 8, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

incorrect background-color when using nzSuffix and nzAddOnAfter

Issue Number: #7247

Close: #7247

What is the new behavior?

correct background-color

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Feb 8, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #7250 (17edbf7) into master (f40aad9) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7250      +/-   ##
==========================================
- Coverage   91.72%   91.72%   -0.01%     
==========================================
  Files         486      486              
  Lines       15918    15950      +32     
  Branches     2588     2591       +3     
==========================================
+ Hits        14601    14630      +29     
- Misses       1004     1010       +6     
+ Partials      313      310       -3     
Impacted Files Coverage Δ
components/input/input-group.component.ts 98.27% <ø> (ø)
components/table/src/table/tr-measure.component.ts 86.36% <0.00%> (-13.64%) ⬇️
components/table/src/table/tbody.component.ts 88.88% <0.00%> (-11.12%) ⬇️
...ts/table/src/table/table-inner-scroll.component.ts 79.41% <0.00%> (-4.42%) ⬇️
components/collapse/collapse.component.ts 94.59% <0.00%> (-0.41%) ⬇️
components/typography/text-edit.component.ts 95.45% <0.00%> (-0.11%) ⬇️
components/slider/slider.component.ts 92.27% <0.00%> (+0.02%) ⬆️
components/collapse/collapse-panel.component.ts 92.85% <0.00%> (+0.26%) ⬆️
components/table/src/cell/th-addon.component.ts 90.12% <0.00%> (+0.37%) ⬆️
components/select/select.component.ts 90.90% <0.00%> (+0.71%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f40aad9...17edbf7. Read the comment docs.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 7acb8db into NG-ZORRO:master Feb 25, 2022
@chenc041 chenc041 deleted the fix-issue-7247 branch June 7, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants