Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:button): prevent default event fire #7267

Merged
merged 5 commits into from Feb 21, 2022

Conversation

chenc041
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7264

What is the new behavior?

When the button state is loading or disabled, the default event will not fire

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Feb 17, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #7267 (be3bf81) into master (0a62944) will increase coverage by 0.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7267      +/-   ##
==========================================
+ Coverage   91.68%   91.75%   +0.06%     
==========================================
  Files         486      486              
  Lines       15920    15950      +30     
  Branches     2588     2591       +3     
==========================================
+ Hits        14597    14635      +38     
+ Misses       1011     1003       -8     
  Partials      312      312              
Impacted Files Coverage Δ
components/button/button.component.ts 98.57% <50.00%> (ø)
components/table/src/table-style.service.ts 94.82% <0.00%> (-1.73%) ⬇️
components/collapse/collapse.component.ts 94.59% <0.00%> (-0.41%) ⬇️
components/typography/text-edit.component.ts 95.45% <0.00%> (-0.11%) ⬇️
components/collapse/collapse-panel.component.ts 92.85% <0.00%> (+0.26%) ⬆️
components/table/src/cell/th-addon.component.ts 90.12% <0.00%> (+0.37%) ⬆️
components/select/select.component.ts 90.90% <0.00%> (+0.71%) ⬆️
components/back-top/back-top.component.ts 91.66% <0.00%> (+0.75%) ⬆️
...ts/table/src/table/table-inner-scroll.component.ts 83.82% <0.00%> (+4.41%) ⬆️
components/table/src/table/tbody.component.ts 100.00% <0.00%> (+11.11%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a62944...be3bf81. Read the comment docs.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants