Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:radio): emit false to the ngModel whenever the radio button is deselected #7270

Merged
merged 1 commit into from Feb 25, 2022

Conversation

arturovt
Copy link
Member

PR Checklist

PR Type

[x] Bugfix

What is the current behavior?

Issue Number: #7254

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@zorro-bot
Copy link

zorro-bot bot commented Feb 19, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #7270 (dc8db25) into master (e541761) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7270      +/-   ##
==========================================
+ Coverage   91.72%   91.76%   +0.03%     
==========================================
  Files         486      486              
  Lines       15950    15953       +3     
  Branches     2591     2593       +2     
==========================================
+ Hits        14630    14639       +9     
+ Misses       1010     1003       -7     
- Partials      310      311       +1     
Impacted Files Coverage Δ
components/radio/radio.component.ts 97.59% <100.00%> (+0.09%) ⬆️
components/table/src/table-style.service.ts 94.82% <0.00%> (-1.73%) ⬇️
components/core/util/text-measure.ts 92.10% <0.00%> (-0.88%) ⬇️
...ts/table/src/table/table-inner-scroll.component.ts 83.82% <0.00%> (+4.41%) ⬆️
components/table/src/table/tbody.component.ts 100.00% <0.00%> (+11.11%) ⬆️
components/table/src/table/tr-measure.component.ts 100.00% <0.00%> (+13.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e541761...dc8db25. Read the comment docs.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 2704237 into NG-ZORRO:master Feb 25, 2022
@arturovt arturovt deleted the fix/7254 branch February 25, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants