Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:collapse): markForCheck after collapse title clicked #7284

Merged
merged 1 commit into from Mar 1, 2022

Conversation

simplejason
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

When collapse title is clicked, it is not collapsed

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Mar 1, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #7284 (7355075) into master (071e084) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 7355075 differs from pull request most recent head ddb4793. Consider uploading reports for the commit ddb4793 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7284   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files         487      487           
  Lines       16000    16002    +2     
  Branches     2602     2602           
=======================================
+ Hits        14660    14662    +2     
  Misses       1030     1030           
  Partials      310      310           
Impacted Files Coverage Δ
components/collapse/collapse-panel.component.ts 93.33% <100.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 071e084...ddb4793. Read the comment docs.

Copy link
Member

@arturovt arturovt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake. LGTM.

@vthinkxie
Copy link
Member

My mistake. LGTM.

Hi, how is everything going in Ukraine, hope you are and continue to be safe 🇺🇦

@vthinkxie vthinkxie merged commit b7433a9 into NG-ZORRO:master Mar 1, 2022
@arturovt
Copy link
Member

arturovt commented Mar 1, 2022

My mistake. LGTM.

Hi, how is everything going in Ukraine, hope you are and continue to be safe 🇺🇦

It’s too bad buddy, just praying for all people to survive!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants