Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:image): do not run change detection when the image preview is clicked #7309

Merged
merged 1 commit into from Apr 21, 2022

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Mar 9, 2022

No description provided.

@zorro-bot
Copy link

zorro-bot bot commented Mar 9, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #7309 (584d9bd) into master (d8ec154) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7309      +/-   ##
==========================================
- Coverage   91.60%   91.57%   -0.03%     
==========================================
  Files         487      487              
  Lines       16006    16007       +1     
  Branches     2604     2604              
==========================================
- Hits        14662    14659       -3     
- Misses       1032     1035       +3     
- Partials      312      313       +1     
Impacted Files Coverage Δ
components/image/image-preview.component.ts 94.19% <100.00%> (+0.03%) ⬆️
components/tabs/tab-nav-bar.component.ts 86.52% <0.00%> (-1.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8ec154...584d9bd. Read the comment docs.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 752a5b6 into NG-ZORRO:master Apr 21, 2022
@arturovt arturovt deleted the perf/image-preview branch April 30, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants