Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:input-number): do not run change detection when mouseup and mouseleave events are dispatched on handlers #7313

Merged
merged 1 commit into from Apr 21, 2022

Conversation

arturovt
Copy link
Member

No description provided.

… and `mouseleave` events are dispatched on handlers
@zorro-bot
Copy link

zorro-bot bot commented Mar 10, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #7313 (f8ac331) into master (2d77bc2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head f8ac331 differs from pull request most recent head 57539a6. Consider uploading reports for the commit 57539a6 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7313      +/-   ##
==========================================
+ Coverage   91.59%   91.61%   +0.01%     
==========================================
  Files         487      487              
  Lines       16006    16008       +2     
  Branches     2604     2604              
==========================================
+ Hits        14660    14665       +5     
+ Misses       1033     1028       -5     
- Partials      313      315       +2     
Impacted Files Coverage Δ
components/input-number/input-number.component.ts 98.64% <100.00%> (+0.01%) ⬆️
components/table/src/table-data.service.ts 80.32% <0.00%> (-4.92%) ⬇️
components/table/src/table-style.service.ts 94.82% <0.00%> (-1.73%) ⬇️
components/core/util/text-measure.ts 92.98% <0.00%> (+0.87%) ⬆️
components/table/src/table/tr-measure.component.ts 91.30% <0.00%> (+4.34%) ⬆️
...ts/table/src/table/table-inner-scroll.component.ts 83.82% <0.00%> (+4.41%) ⬆️
components/table/src/table/tbody.component.ts 100.00% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d77bc2...57539a6. Read the comment docs.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 54386ef into NG-ZORRO:master Apr 21, 2022
@arturovt arturovt deleted the perf/input-number-stop branch April 30, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants