fix(module:list): re-enter the Angular zone when the NgZone.onStable emits
#7314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` emits The `NgZone.onStable` always emits outside of the Angular zone, but the zone has not been re-entered. This leads to change detection being called outside of the Angular zone.
Codecov Report
@@ Coverage Diff @@
## master #7314 +/- ##
=======================================
Coverage 91.59% 91.59%
=======================================
Files 487 487
Lines 16006 16005 -1
Branches 2604 2604
=======================================
Hits 14660 14660
+ Misses 1033 1032 -1
Partials 313 313
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NgZone.onStablealways emits outside of the Angular zone, but the zone has not beenre-entered. This leads to change detection being called outside of the Angular zone.