Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:typography): focus the element and set the value even if the zone is already stable #7320

Merged
merged 1 commit into from Sep 27, 2022

Conversation

arturovt
Copy link
Member

No description provided.

@zorro-bot
Copy link

zorro-bot bot commented Mar 12, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 12, 2022

Codecov Report

Merging #7320 (d3a097a) into master (f18149a) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

❗ Current head d3a097a differs from pull request most recent head 0e7916d. Consider uploading reports for the commit 0e7916d to get more accurate results

@@            Coverage Diff             @@
##           master    #7320      +/-   ##
==========================================
- Coverage   91.74%   91.62%   -0.12%     
==========================================
  Files         502      487      -15     
  Lines       16756    16013     -743     
  Branches     2757     2606     -151     
==========================================
- Hits        15372    14672     -700     
+ Misses       1050     1027      -23     
+ Partials      334      314      -20     
Impacted Files Coverage Δ
components/typography/text-edit.component.ts 95.45% <100.00%> (ø)
components/date-picker/week-picker.component.ts 33.33% <0.00%> (-66.67%) ⬇️
components/date-picker/year-picker.component.ts 33.33% <0.00%> (-66.67%) ⬇️
components/date-picker/month-picker.component.ts 33.33% <0.00%> (-66.67%) ⬇️
components/core/config/config.service.ts 91.17% <0.00%> (-6.26%) ⬇️
components/steps/steps.component.ts 94.80% <0.00%> (-5.20%) ⬇️
components/input/input.directive.ts 93.93% <0.00%> (-4.64%) ⬇️
components/form/form.directive.ts 93.33% <0.00%> (-3.34%) ⬇️
components/time-picker/time-picker.component.ts 88.75% <0.00%> (-2.12%) ⬇️
components/core/overlay/overlay-position.ts 90.90% <0.00%> (-1.40%) ⬇️
... and 67 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@arturovt arturovt changed the title fix(module:typography): avoid infinite loop when the zone-patch-rxjs is used fix(module:typography): focus the element and set the value even if the zone is already stable Mar 22, 2022
Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 2d2fe33 into NG-ZORRO:master Sep 27, 2022
@arturovt arturovt deleted the fix/typography-loop branch September 27, 2022 14:31
chenc041 pushed a commit to chenc041/ng-zorro-antd that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants