Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:carousel): fix nzAfterChange callback value not correctly #7326

Merged
merged 1 commit into from Mar 21, 2022

Conversation

chenc041
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7323

What is the new behavior?

nzAfterChange callback return correctly
Closed: #7323

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Mar 19, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 19, 2022

Codecov Report

Merging #7326 (c50a5d5) into master (2d77bc2) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7326      +/-   ##
==========================================
+ Coverage   91.59%   91.63%   +0.04%     
==========================================
  Files         487      487              
  Lines       16006    16006              
  Branches     2604     2604              
==========================================
+ Hits        14660    14667       +7     
+ Misses       1033     1025       -8     
- Partials      313      314       +1     
Impacted Files Coverage Δ
components/carousel/carousel.component.ts 92.68% <100.00%> (ø)
components/table/src/table-style.service.ts 94.82% <0.00%> (-1.73%) ⬇️
components/tabs/tab-nav-bar.component.ts 87.94% <0.00%> (+0.70%) ⬆️
components/table/src/table/tr-measure.component.ts 91.30% <0.00%> (+4.34%) ⬆️
...ts/table/src/table/table-inner-scroll.component.ts 83.82% <0.00%> (+4.41%) ⬆️
components/table/src/table/tbody.component.ts 100.00% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d77bc2...c50a5d5. Read the comment docs.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@simplejason simplejason merged commit b517bd4 into NG-ZORRO:master Mar 21, 2022
@chenc041 chenc041 deleted the fix-issue-7323 branch June 7, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

carousel切换页面bug
3 participants