Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:modal): no longer trigger any action when closing #7336

Merged
merged 1 commit into from Apr 21, 2022
Merged

fix(module:modal): no longer trigger any action when closing #7336

merged 1 commit into from Apr 21, 2022

Conversation

maroon1
Copy link
Contributor

@maroon1 maroon1 commented Mar 25, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

目前在关闭 Modal 的动画窗口期仍然能够触发 nzOnOKnzOnCancel,造成用户意外的双击或者快速点击的情况下会重复的触发事件
Issue Number: N/A

What is the new behavior?

当 Modal 处于 Closing 状态下时,将忽略 nzOnOKnzOnCancel 的事件

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Mar 25, 2022

This preview will be available after the AzureCI is passed.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit d169452 into NG-ZORRO:master Apr 21, 2022
@maroon1 maroon1 deleted the maroon1/closing-action branch April 28, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants