feat(module:code-editor): support MonacoEnvironment config in NZ_CONFIG #7359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangjunhan
force-pushed
the
feat/MonacoEnvironment
branch
from
6f37155
to
ee667a4
Compare
Codecov Report
@@ Coverage Diff @@
## master #7359 +/- ##
=======================================
Coverage 91.62% 91.62%
=======================================
Files 487 487
Lines 16013 16015 +2
Branches 2604 2605 +1
=======================================
+ Hits 14672 14674 +2
Misses 1027 1027
Partials 314 314
Continue to review full report at Codecov.
|
wzhudev
reviewed
Apr 27, 2022
| @@ -3,11 +3,17 @@ | |||
| * found in the LICENSE file at https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/LICENSE | |||
| */ | |||
|
|
|||
| import { editor } from 'monaco-editor'; | |||
| import { editor, Environment } from 'monaco-editor'; | |||
There was a problem hiding this comment.
@yangjunhan Should not import the type declaration here. Forcing users to install monaco-editor even if they are not actually using it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #6502
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #6502
What is the new behavior?
From microsoft/monaco-editor changelog:
NZ_CONFIG code-editor config support modifying
window.MonacoEnvironmentDoes this PR introduce a breaking change?
Other information