Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:segmented): implement new component #7404

Merged
merged 7 commits into from May 18, 2022

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Apr 30, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Apr 30, 2022

Codecov Report

Merging #7404 (6c7e6b0) into master (f09ba57) will increase coverage by 0.01%.
The diff coverage is 95.52%.

@@            Coverage Diff             @@
##           master    #7404      +/-   ##
==========================================
+ Coverage   91.61%   91.62%   +0.01%     
==========================================
  Files         487      491       +4     
  Lines       16043    16110      +67     
  Branches     2610     2617       +7     
==========================================
+ Hits        14698    14761      +63     
- Misses       1031     1034       +3     
- Partials      314      315       +1     
Impacted Files Coverage Δ
components/core/config/config.ts 100.00% <ø> (ø)
components/segmented/segmented.component.ts 95.00% <95.00%> (ø)
components/core/animation/thumb.ts 100.00% <100.00%> (ø)
components/segmented/segmented.module.ts 100.00% <100.00%> (ø)
components/segmented/types.ts 100.00% <100.00%> (ø)
components/table/src/table-data.service.ts 80.32% <0.00%> (-4.92%) ⬇️
components/tabs/tab-nav-bar.component.ts 87.23% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f09ba57...6c7e6b0. Read the comment docs.

@wzhudev wzhudev mentioned this pull request May 1, 2022
58 tasks
Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 95a31da into NG-ZORRO:master May 18, 2022
@pr-triage pr-triage bot added the PR: merged label May 18, 2022
@wzhudev wzhudev deleted the feat-new-component-segmented branch May 18, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants