Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:badge): support size #7405

Merged
merged 1 commit into from Jul 11, 2022
Merged

feat(module:badge): support size #7405

merged 1 commit into from Jul 11, 2022

Conversation

buqiyuan
Copy link
Collaborator

@buqiyuan buqiyuan commented May 1, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented May 1, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 1, 2022

Codecov Report

Merging #7405 (9fd5cd4) into master (f09ba57) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7405      +/-   ##
==========================================
+ Coverage   91.61%   91.65%   +0.04%     
==========================================
  Files         487      491       +4     
  Lines       16043    16112      +69     
  Branches     2610     2483     -127     
==========================================
+ Hits        14698    14768      +70     
+ Misses       1031     1030       -1     
  Partials      314      314              
Impacted Files Coverage Δ
components/badge/ribbon.component.ts 33.33% <ø> (ø)
components/badge/badge-sup.component.ts 100.00% <100.00%> (ø)
components/badge/badge.component.ts 100.00% <100.00%> (ø)
components/core/config/config.ts 100.00% <0.00%> (ø)
components/segmented/types.ts 100.00% <0.00%> (ø)
components/segmented/segmented.module.ts 100.00% <0.00%> (ø)
components/core/animation/thumb.ts 100.00% <0.00%> (ø)
components/segmented/segmented.component.ts 95.00% <0.00%> (ø)
components/tabs/tab-nav-bar.component.ts 87.94% <0.00%> (+1.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f09ba57...9fd5cd4. Read the comment docs.

@simplejason
Copy link
Member

👍 点赞,如果你有钉钉账号的话并且愿意的话,我希望将你拉到钉钉群和微信群的开发者群中 :)

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@buqiyuan
Copy link
Collaborator Author

👍 点赞,如果你有钉钉账号的话并且愿意的话,我希望将你拉到钉钉群和微信群的开发者群中 :)

谢谢~非常荣幸能加入到你们开发中去!我的钉钉号:buqiyuan,微信号:bqy_fe

@simplejason
Copy link
Member

buqiyuan

钉钉号有吗?按名称搜不到用户,或者可以从zorro群加我哈

@buqiyuan
Copy link
Collaborator Author

buqiyuan commented May 25, 2022

buqiyuan

钉钉号有吗?按名称搜不到用户,或者可以从zorro群加我哈

image
文档中分享的群二维码貌似过期了

@simplejason

This comment was marked as outdated.

@simplejason

This comment was marked as outdated.

@buqiyuan
Copy link
Collaborator Author

这个是你吗 image

是的

@simplejason simplejason merged commit f40dd38 into NG-ZORRO:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants