Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:transfer): submit behavior for button inside form #7413

Merged
merged 1 commit into from May 26, 2022

Conversation

volvachev
Copy link
Contributor

Fixes #7410.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Inside the form, the transfer component is triggered by moving to the right/left on the enter command.

Issue Number: #7410

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@zorro-bot
Copy link

zorro-bot bot commented May 5, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #7413 (7f68529) into master (f09ba57) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7413      +/-   ##
==========================================
+ Coverage   91.61%   91.62%   +0.01%     
==========================================
  Files         487      487              
  Lines       16043    16043              
  Branches     2610     2610              
==========================================
+ Hits        14698    14700       +2     
+ Misses       1031     1029       -2     
  Partials      314      314              
Impacted Files Coverage Δ
components/transfer/transfer.component.ts 93.27% <ø> (ø)
components/tabs/tab-nav-bar.component.ts 87.23% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f09ba57...7f68529. Read the comment docs.

@volvachev
Copy link
Contributor Author

@wenqi73, Hi could you do a review of the pull request?

Copy link
Member

@wenqi73 wenqi73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NZ-TRANSFER] if we put the nz-tranfer component in a form, it will submit the form on firefox
3 participants