Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:transfer): uncheck "Select all" checkbox when filtered items are moved #7419

Merged
merged 1 commit into from Jul 11, 2022

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented May 9, 2022

Closes #6667

@zorro-bot
Copy link

zorro-bot bot commented May 9, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #7419 (d2e3c28) into master (ff8599b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d2e3c28 differs from pull request most recent head 6c8302d. Consider uploading reports for the commit 6c8302d to get more accurate results

@@           Coverage Diff           @@
##           master    #7419   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         487      487           
  Lines       16043    16044    +1     
  Branches     2610     2611    +1     
=======================================
+ Hits        14702    14703    +1     
  Misses       1028     1028           
  Partials      313      313           
Impacted Files Coverage Δ
components/transfer/transfer-list.component.ts 96.77% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff8599b...6c8302d. Read the comment docs.

@arturovt arturovt changed the title fix(module:transfer): uncheck "Select all" checkbox when filters items are moved fix(module:transfer): uncheck "Select all" checkbox when filtered items are moved May 9, 2022
@arturovt arturovt requested a review from wzhudev May 9, 2022 12:45
Copy link
Member

@wenqi73 wenqi73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@simplejason simplejason merged commit 1e9c11e into NG-ZORRO:master Jul 11, 2022
@arturovt arturovt deleted the fix/transfer-6667 branch July 11, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in Transfer
3 participants