Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:menu): add support nzPlacement for nz-submenu #7420

Merged
merged 1 commit into from Sep 26, 2022

Conversation

klerick
Copy link
Contributor

@klerick klerick commented May 10, 2022

Closes #4743

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4743

What is the new behavior?

Add new option for set position sub-menu

Does this PR introduce a breaking change?

[ ] Yes
[x ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented May 10, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #7420 (c8884ee) into master (ff8599b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c8884ee differs from pull request most recent head c1d9179. Consider uploading reports for the commit c1d9179 to get more accurate results

@@           Coverage Diff           @@
##           master    #7420   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         487      487           
  Lines       16043    16045    +2     
  Branches     2610     2611    +1     
=======================================
+ Hits        14702    14704    +2     
  Misses       1028     1028           
  Partials      313      313           
Impacted Files Coverage Δ
components/core/overlay/overlay-position.ts 90.90% <ø> (ø)
components/menu/submenu.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff8599b...c1d9179. Read the comment docs.

@simplejason
Copy link
Member

I don't think we need to expose the concept of placement to users, the better way is that we should fix the menu being obscured with cdkConnectedOverlayPositions.

@klerick
Copy link
Contributor Author

klerick commented May 15, 2022

I don't think we need to expose the concept of placement to users, the better way is that we should fix the menu being obscured with cdkConnectedOverlayPositions.

#4743
allready opened halve year but does not have progress.

I dont find solution it fix use cdkConnectedOverlayPositions.
i try to recalculate position on run time, but it looks like hack

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit b1223bd into NG-ZORRO:master Sep 26, 2022
@pr-triage pr-triage bot added the PR: merged label Sep 26, 2022
chenc041 pushed a commit to chenc041/ng-zorro-antd that referenced this pull request Dec 14, 2022
)

Closes NG-ZORRO#4743

Co-authored-by: Alexander Kharkovey <alexander.kharkovey@nordigy.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat request: support nzPlacement in nz-menu / nz-submenu
2 participants