Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tree-view): trigger markforcheck after nodes changed #7426

Merged
merged 1 commit into from May 12, 2022

Conversation

simplejason
Copy link
Member

@simplejason simplejason commented May 12, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented May 12, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #7426 (4489b63) into master (ff8599b) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7426      +/-   ##
==========================================
- Coverage   91.64%   91.62%   -0.02%     
==========================================
  Files         487      487              
  Lines       16043    16043              
  Branches     2610     2610              
==========================================
- Hits        14702    14699       -3     
- Misses       1028     1030       +2     
- Partials      313      314       +1     
Impacted Files Coverage Δ
components/tabs/tab-nav-bar.component.ts 86.52% <0.00%> (-1.42%) ⬇️
components/core/util/text-measure.ts 92.98% <0.00%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff8599b...4489b63. Read the comment docs.

Copy link
Contributor

@yangjunhan yangjunhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangjunhan yangjunhan merged commit a702674 into NG-ZORRO:master May 12, 2022
@simplejason simplejason deleted the fix/tree-view branch May 12, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants