Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tooltip): is not aligned on first display #7457

Merged
merged 1 commit into from Jun 15, 2022

Conversation

volvachev
Copy link
Contributor

In some cases, the rendering takes into account the height at which the arrow is in wrong place, so cdk sets the container position incorrectly.

To avoid this, after placing the arrow in the correct position, we should re-calculate the position of the overlay.

Fixes #7453.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7453

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@volvachev volvachev requested a review from wzhudev as a code owner May 24, 2022 06:35
@zorro-bot
Copy link

zorro-bot bot commented May 24, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #7457 (31854a3) into master (111abf3) will decrease coverage by 0.09%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master    #7457      +/-   ##
==========================================
- Coverage   91.64%   91.55%   -0.10%     
==========================================
  Files         491      496       +5     
  Lines       16110    16302     +192     
  Branches     2483     2530      +47     
==========================================
+ Hits        14764    14925     +161     
- Misses       1034     1051      +17     
- Partials      312      326      +14     
Impacted Files Coverage Δ
components/tooltip/base.ts 93.69% <88.88%> (-0.32%) ⬇️
components/table/src/table-style.service.ts 94.82% <0.00%> (-1.73%) ⬇️
components/core/config/config.ts 100.00% <0.00%> (ø)
components/core/util/can-use-dom.ts 100.00% <0.00%> (ø)
components/core/config/css-variables.ts 87.23% <0.00%> (ø)
components/core/util/dynamic-css.ts 74.00% <0.00%> (ø)
components/core/util/status-util.ts 100.00% <0.00%> (ø)
components/core/color/generate.ts 77.27% <0.00%> (ø)
components/cascader/cascader.component.ts 98.12% <0.00%> (+0.07%) ⬆️
components/table/src/table/tr-measure.component.ts 91.30% <0.00%> (+4.34%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 111abf3...31854a3. Read the comment docs.

@simplejason
Copy link
Member

@hullis Please leave your comments if you have time to deal with it :)

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip is not aligned on first display
3 participants