Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:form): make form work with status #7489

Merged
merged 17 commits into from Jun 15, 2022

Conversation

simplejason
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jun 2, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #7489 (a6be6ea) into master (ba6bade) will increase coverage by 0.08%.
The diff coverage is 96.32%.

@@            Coverage Diff             @@
##           master    #7489      +/-   ##
==========================================
+ Coverage   91.64%   91.73%   +0.08%     
==========================================
  Files         498      502       +4     
  Lines       16512    16692     +180     
  Branches     2559     2605      +46     
==========================================
+ Hits        15133    15312     +179     
+ Misses       1056     1049       -7     
- Partials      323      331       +8     
Impacted Files Coverage Δ
components/cascader/cascader.module.ts 100.00% <ø> (ø)
components/date-picker/date-picker.module.ts 100.00% <ø> (ø)
components/grid/row.directive.ts 100.00% <ø> (ø)
.../input-number/input-number-group-slot.component.ts 100.00% <ø> (ø)
components/input-number/input-number.module.ts 100.00% <ø> (ø)
components/input/input.module.ts 100.00% <ø> (ø)
components/mention/mention.module.ts 100.00% <ø> (ø)
components/page-header/demo/actions.ts 100.00% <ø> (ø)
components/page-header/demo/content.ts 100.00% <ø> (ø)
components/page-header/demo/ghost.ts 100.00% <ø> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba6bade...a6be6ea. Read the comment docs.

@simplejason simplejason changed the title WIP feat(module:form): make form work with status feat(module:form): make form work with status Jun 10, 2022
Copy link
Contributor

@yangjunhan yangjunhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 98ac620 into NG-ZORRO:master Jun 15, 2022
@simplejason simplejason deleted the feat/form-status branch June 15, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants