Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:icon): add missing zorro used icon: deleteOutline #7499

Merged
merged 1 commit into from Jun 15, 2022

Conversation

msyesyan
Copy link
Contributor

@msyesyan msyesyan commented Jun 7, 2022

deleteOutline is used in nz-upload-list

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

deleteOutline is used in nz-upload-list
@zorro-bot
Copy link

zorro-bot bot commented Jun 7, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #7499 (e828fae) into master (f299c3f) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7499      +/-   ##
==========================================
- Coverage   91.64%   91.63%   -0.02%     
==========================================
  Files         498      498              
  Lines       16512    16512              
  Branches     2559     2559              
==========================================
- Hits        15133    15131       -2     
- Misses       1056     1057       +1     
- Partials      323      324       +1     
Impacted Files Coverage Δ
components/icon/icons.ts 100.00% <ø> (ø)
components/tabs/tab-nav-bar.component.ts 87.23% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f299c3f...e828fae. Read the comment docs.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@msyesyan
Copy link
Contributor Author

msyesyan commented Jun 7, 2022

@hullis
I haven't changed the file components/tabs/tab-nav-bar.component.ts, is this a coverage tool issue? do you know how to fix this?

@wzhudev
Copy link
Member

wzhudev commented Jun 10, 2022

@hullis I haven't changed the file components/tabs/tab-nav-bar.component.ts, is this a coverage tool issue? do you know how to fix this?

There is some issue with the covdecov bot. Don't worry. We will merge this anyway.

@simplejason simplejason merged commit ba6bade into NG-ZORRO:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants