Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:pagination): add ul tag #7500

Merged
merged 6 commits into from Aug 23, 2022

Conversation

chenc041
Copy link
Contributor

@chenc041 chenc041 commented Jun 7, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The pagination component missing ul tag
Issue Number: #7493

Close: #7493

What is the new behavior?

Add ul tag

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jun 7, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #7500 (98a604b) into master (a142eb2) will not change coverage.
The diff coverage is n/a.

❗ Current head 98a604b differs from pull request most recent head 9ec0753. Consider uploading reports for the commit 9ec0753 to get more accurate results

@@           Coverage Diff           @@
##           master    #7500   +/-   ##
=======================================
  Coverage   92.08%   92.08%           
=======================================
  Files         502      502           
  Lines       16752    16752           
  Branches     2629     2629           
=======================================
  Hits        15426    15426           
  Misses       1057     1057           
  Partials      269      269           
Impacted Files Coverage Δ
...ponents/pagination/pagination-default.component.ts 97.61% <ø> (ø)
...ponents/pagination/pagination-options.component.ts 92.59% <ø> (ø)
...mponents/pagination/pagination-simple.component.ts 92.15% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@simplejason
Copy link
Member

If you don't mind, I'll fix the testing codes and then we can merge it :)

@chenc041
Copy link
Contributor Author

If you don't mind, I'll fix the testing codes and then we can merge it :)

ok~

@chenc041
Copy link
Contributor Author

chenc041 commented Aug 23, 2022

I submitted for the first time, and all of the ci is passed, but after a period of time, not line, this is to have a change?
@simplejason

@simplejason
Copy link
Member

simplejason commented Aug 23, 2022

I submitted for the first time, and all of the ci is passed, but after a period of time, not line, this is to have a change? @simplejason

I think it is caused by the className .ant-pagination, I will keep it on nz-pagination for now. Previously I expected the same dom as ant-design, but it breaks the existing tests, so I will rollback it for now
Of course you are welcome to submit code if you wish :)

1. add `class: 'ant-pagination'` to `host` of `nz-pagination`
2. remove `.ant-pagination` from the ul tag of `nz-pagination-default` and `nz-pagination-simple`

update: done

@chenc041
Copy link
Contributor Author

I submitted for the first time, and all of the ci is passed, but after a period of time, not line, this is to have a change? @simplejason

I think it is caused by the className .ant-pagination, I will keep it on nz-pagination for now. Previously I expected the same dom as ant-design, but it breaks the existing tests, so I will rollback it for now Of course you are welcome to submit code if you wish :)

1. add `class: 'ant-pagination'` to `host` of `nz-pagination`
2. remove `.ant-pagination` from the ul tag of `nz-pagination-default` and `nz-pagination-simple`

update: done

thks

@simplejason
Copy link
Member

@chenc041 After CI passed, I will merge it and it will be released with ng-zorro-antd@14.0.0 in this week, thanks for your contributions

@chenc041
Copy link
Contributor Author

@chenc041 After CI passed, I will merge it and it will be released with ng-zorro-antd@14.0.0 in this week, thanks for your contributions

ok~
You are welcome

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit becdd68 into NG-ZORRO:master Aug 23, 2022
@chenc041 chenc041 deleted the fix-issue-7493 branch December 14, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<ul> tag is missing in the pagination component
3 participants