Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:datepicker): focus input when opened programmatically #7512

Merged
merged 1 commit into from Jul 11, 2022

Conversation

sebcam
Copy link
Contributor

@sebcam sebcam commented Jun 16, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

When opening a datepicker by code using open() function, the picker open fine but the picker input is not focused, involving problems to exit picker.
Can be reproduce on the customized range picker exemple here

Issue Number: N/A

What is the new behavior?

When opening by code, picket input get focused if not already.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #7512 (15d3252) into master (3680ed9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7512      +/-   ##
==========================================
+ Coverage   91.71%   91.72%   +0.01%     
==========================================
  Files         502      502              
  Lines       16697    16698       +1     
  Branches     2606     2752     +146     
==========================================
+ Hits        15314    15317       +3     
+ Misses       1050     1049       -1     
+ Partials      333      332       -1     
Impacted Files Coverage Δ
components/date-picker/date-picker.component.ts 92.60% <100.00%> (+0.02%) ⬆️
components/tabs/tab-nav-bar.component.ts 87.94% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3680ed9...15d3252. Read the comment docs.

Copy link
Member

@wenqi73 wenqi73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants