New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:date-picker): support date-picker placement #7527
feat(module:date-picker): support date-picker placement #7527
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #7527 +/- ##
==========================================
- Coverage 91.73% 91.72% -0.01%
==========================================
Files 502 502
Lines 16699 16710 +11
Branches 2750 2605 -145
==========================================
+ Hits 15319 15328 +9
- Misses 1050 1054 +4
+ Partials 330 328 -2
Continue to review full report at Codecov.
|
63a84f1
to
b2184fe
Compare
b2184fe
to
e13f07d
Compare
setPlacement(placement: NzPlacement): void { | ||
const position: ConnectionPositionPair = | ||
DATE_PICKER_POSITION_MAP[placement as keyof typeof DATE_PICKER_POSITION_MAP]; | ||
this.overlayPositions = [position]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
还得有多个 position,否则滚动屏幕后 overlay 不会自动换位置。
参考下
ng-zorro-antd/components/tooltip/base.ts
Line 374 in ea1138b
this._positions = [...preferredPosition, ...DEFAULT_TOOLTIP_POSITIONS]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的,我以为指定之后,就不能自动更换了👌🏻
e13f07d
to
d19fe85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good job!
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #7389
What is the new behavior?
Does this PR introduce a breaking change?
Other information