Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:input-number): fix errors before initialization #7531

Merged
merged 1 commit into from Jun 25, 2022

Conversation

simplejason
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7525

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jun 25, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #7531 (3b43fd8) into master (44d9770) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           master    #7531    +/-   ##
========================================
  Coverage   91.73%   91.74%            
========================================
  Files         502      502            
  Lines       16699    16699            
  Branches     2750     2604   -146     
========================================
+ Hits        15319    15320     +1     
+ Misses       1050     1048     -2     
- Partials      330      331     +1     
Impacted Files Coverage Δ
...nents/input-number/input-number-group.component.ts 98.96% <ø> (ø)
components/input-number/input-number.module.ts 100.00% <ø> (ø)
components/input/input-group.component.ts 98.96% <ø> (ø)
components/input-number/input-number.component.ts 99.60% <100.00%> (ø)
components/input/input.directive.ts 98.57% <100.00%> (ø)
components/tabs/tab-nav-bar.component.ts 87.23% <0.00%> (-0.71%) ⬇️
components/table/src/table-data.service.ts 85.24% <0.00%> (+4.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44d9770...3b43fd8. Read the comment docs.

@simplejason simplejason merged commit 800e6f4 into NG-ZORRO:master Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant