Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: popconfirm): support async close #7533

Merged
merged 1 commit into from Aug 4, 2022

Conversation

rorry121
Copy link
Contributor

@rorry121 rorry121 commented Jun 26, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jun 26, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 26, 2022

Codecov Report

Merging #7533 (071c266) into master (64b7389) will decrease coverage by 0.02%.
The diff coverage is 88.63%.

❗ Current head 071c266 differs from pull request most recent head b391aee. Consider uploading reports for the commit b391aee to get more accurate results

@@            Coverage Diff             @@
##           master    #7533      +/-   ##
==========================================
- Coverage   91.75%   91.72%   -0.03%     
==========================================
  Files         502      502              
  Lines       16699    16770      +71     
  Branches     2604     2759     +155     
==========================================
+ Hits        15322    15383      +61     
- Misses       1047     1053       +6     
- Partials      330      334       +4     
Impacted Files Coverage Δ
components/anchor/anchor-link.component.ts 100.00% <ø> (ø)
components/badge/ribbon.component.ts 33.33% <ø> (ø)
components/core/animation/notification.ts 100.00% <ø> (ø)
components/core/config/config.ts 100.00% <ø> (ø)
components/notification/notification.component.ts 90.00% <66.66%> (-10.00%) ⬇️
...s/notification/notification-container.component.ts 93.67% <84.00%> (-4.61%) ⬇️
components/popconfirm/popconfirm.ts 96.70% <87.50%> (-2.00%) ⬇️
components/anchor/anchor.component.ts 97.47% <90.00%> (-1.57%) ⬇️
components/badge/badge-sup.component.ts 100.00% <100.00%> (ø)
components/badge/badge.component.ts 100.00% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

)
.subscribe(value => {
if (value) {
this.nzOnConfirm.next();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L291-292 & L296-297 could be extracted to a function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated!

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 797b261 into NG-ZORRO:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants