Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: select): support placement #7537

Merged
merged 1 commit into from Sep 26, 2022

Conversation

rorry121
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@rorry121 rorry121 requested a review from vthinkxie as a code owner June 28, 2022 17:07
@zorro-bot
Copy link

zorro-bot bot commented Jun 28, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #7537 (e8b1f15) into master (aecb788) will decrease coverage by 0.04%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master    #7537      +/-   ##
==========================================
- Coverage   92.03%   91.99%   -0.05%     
==========================================
  Files         502      502              
  Lines       16736    16746      +10     
  Branches     2629     2631       +2     
==========================================
+ Hits        15403    15405       +2     
- Misses       1064     1072       +8     
  Partials      269      269              
Impacted Files Coverage Δ
components/select/select.component.ts 91.29% <84.61%> (-0.33%) ⬇️
components/table/src/table/tbody.component.ts 88.88% <0.00%> (-11.12%) ⬇️
...ts/table/src/table/table-inner-scroll.component.ts 79.41% <0.00%> (-4.42%) ⬇️
components/table/src/table/tr-measure.component.ts 86.95% <0.00%> (-4.35%) ⬇️
components/tabs/tab-nav-bar.component.ts 87.23% <0.00%> (-0.71%) ⬇️
components/core/util/text-measure.ts 92.98% <0.00%> (+0.87%) ⬆️
components/table/src/table-style.service.ts 96.55% <0.00%> (+1.72%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit dda0e6d into NG-ZORRO:master Sep 26, 2022
@pr-triage pr-triage bot added the PR: merged label Sep 26, 2022
chenc041 pushed a commit to chenc041/ng-zorro-antd that referenced this pull request Dec 14, 2022
Co-authored-by: luolei <luolei@kuaishou.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants