feat(module: notification): support top and bottom placement #7540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #7540 +/- ##
==========================================
- Coverage 91.75% 91.70% -0.05%
==========================================
Files 502 502
Lines 16699 16723 +24
Branches 2604 2605 +1
==========================================
+ Hits 15322 15336 +14
- Misses 1047 1057 +10
Partials 330 330
Continue to review full report at Codecov.
|
rorry121
commented
Jun 29, 2022
| @@ -43,7 +43,7 @@ const NZ_NOTIFICATION_DEFAULT_CONFIG: Required<NotificationConfig> = { | |||
| <nz-notification | |||
| *ngFor="let instance of topLeftInstances" | |||
| [instance]="instance" | |||
| [placement]="config.nzPlacement" | |||
| [placement]="instance.options.nzPlacement" | |||
There was a problem hiding this comment.
Here is the fix for the wrong direction of the notifactionMotion
wzhudev
reviewed
Jul 1, 2022
| @@ -172,6 +202,8 @@ export class NzNotificationContainerComponent extends NzMNContainerComponent { | |||
| this.topRightInstances = this.instances.filter(m => m.options.nzPlacement === 'topRight' || !m.options.nzPlacement); | |||
| this.bottomLeftInstances = this.instances.filter(m => m.options.nzPlacement === 'bottomLeft'); | |||
| this.bottomRightInstances = this.instances.filter(m => m.options.nzPlacement === 'bottomRight'); | |||
| this.topInstances = this.instances.filter(m => m.options.nzPlacement === 'top'); | |||
| this.bottomInstances = this.instances.filter(m => m.options.nzPlacement === 'bottom'); | |||
There was a problem hiding this comment.
Maybe we can do these in one loop?
rorry121
force-pushed
the
feat/notifaction-placement
branch
from
055652d
to
afcbc0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #7389
What is the new behavior?
Does this PR introduce a breaking change?
Other information