Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tree-select): update nzPlacement demo #7551

Merged
merged 12 commits into from Dec 11, 2022

Conversation

JackYumg
Copy link
Contributor

@JackYumg JackYumg commented Jul 4, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@JackYumg JackYumg requested a review from hsuanxyz as a code owner July 4, 2022 03:52
@zorro-bot
Copy link

zorro-bot bot commented Jul 4, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #7551 (341f540) into master (64b7389) will decrease coverage by 0.03%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #7551      +/-   ##
==========================================
- Coverage   91.75%   91.72%   -0.04%     
==========================================
  Files         502      502              
  Lines       16699    16706       +7     
  Branches     2604     2607       +3     
==========================================
+ Hits        15322    15323       +1     
- Misses       1047     1050       +3     
- Partials      330      333       +3     
Impacted Files Coverage Δ
components/tree-select/tree-select.component.ts 90.49% <66.66%> (-0.92%) ⬇️
components/tabs/tab-nav-bar.component.ts 86.52% <0.00%> (-1.42%) ⬇️
components/core/util/text-measure.ts 92.98% <0.00%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64b7389...341f540. Read the comment docs.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 325971e into NG-ZORRO:master Dec 11, 2022
chenc041 pushed a commit to chenc041/ng-zorro-antd that referenced this pull request Dec 14, 2022
* feat(module:tree-select): add status

add 'nzStatus' , display diffrent status of tree-select

* docs  update 'nzStatus' docs

* test add 'nzStatus' tests

* docs(module:tree-select): update status docs
 * update 'status' demo

* fix(module:tree-select): add 'NzSpaceModule'
 * fix  module of demo need to depend on NzSpaceModule

* feat(module:tree-select): add placement

add 'nzPlacement' , display drop  on diffrent placement of tree-select

* docs  update 'nzPlacement' docs

* style(module:tree-select): update code style

* style update code style

* fix(module:tree-select): update nzPlacement

* fix(module:tree-select): update nzPlacement

* fix(module:tree-select): update nzPlacement

* fix(module:tree-select): update nzPlacement demo

Co-authored-by: wethin <806769481@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants