Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: tree): nz-tree-drop-indicator for custom tree node templates #7579

Merged
merged 1 commit into from Dec 11, 2022

Conversation

Zarlex
Copy link
Contributor

@Zarlex Zarlex commented Jul 27, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The nz-tree-drop-indicator is only rendered for tree nodes if no custom treeTemplate is provided

Issue Number: N/A

What is the new behavior?

The nz-tree-drop-indicator is also rendered for tree nodes with a custom treeTemplate

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

In this screenshot you can see the new behaviour: https://www.awesomescreenshot.com/video/10188107
The first tree uses a custom node template, the other tree does not
In both trees you can now see the drop-indicator

The tree was taken from https://ng.ant.design/components/tree/en

@zorro-bot
Copy link

zorro-bot bot commented Jul 27, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #7579 (610bcf6) into master (f18149a) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7579      +/-   ##
==========================================
- Coverage   91.74%   91.73%   -0.01%     
==========================================
  Files         502      502              
  Lines       16756    16756              
  Branches     2757     2757              
==========================================
- Hits        15372    15371       -1     
- Misses       1050     1051       +1     
  Partials      334      334              
Impacted Files Coverage Δ
components/tree/tree-node-title.component.ts 100.00% <ø> (ø)
components/core/util/text-measure.ts 92.10% <0.00%> (-0.88%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@behdi
Copy link
Contributor

behdi commented Aug 23, 2022

+1. Heavily needed feature.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 5996019 into NG-ZORRO:master Dec 11, 2022
chenc041 pushed a commit to chenc041/ng-zorro-antd that referenced this pull request Dec 14, 2022
…tes (NG-ZORRO#7579)

Co-authored-by: Alexander Zarges <az@radiosphere.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants