Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:image): preview the local upload image error #7615

Merged
merged 1 commit into from Nov 17, 2022

Conversation

chenc041
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7576
Close: #7576

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #7615 (3bf9570) into master (becdd68) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7615      +/-   ##
==========================================
+ Coverage   92.08%   92.10%   +0.01%     
==========================================
  Files         502      502              
  Lines       16752    16755       +3     
  Branches     2629     2629              
==========================================
+ Hits        15426    15432       +6     
+ Misses       1057     1055       -2     
+ Partials      269      268       -1     
Impacted Files Coverage Δ
components/image/image-preview.component.ts 94.30% <100.00%> (+0.11%) ⬆️
components/tabs/tab-nav-bar.component.ts 88.65% <0.00%> (+0.70%) ⬆️
components/core/util/text-measure.ts 92.98% <0.00%> (+0.87%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 616f59f into NG-ZORRO:master Nov 17, 2022
@chenc041 chenc041 deleted the fix-issue-7576 branch December 14, 2022 06:44
chenc041 added a commit to chenc041/ng-zorro-antd that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image图片组件本地预览时,如果点击放大时会加载失败
2 participants