Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:segmented): fix index.less not imported in entry.less #7624

Merged

Conversation

laggage
Copy link
Contributor

@laggage laggage commented Sep 3, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

My project import style of zorro as required

@import '~node_modules/ng-zorro-antd/tabs/style/entry.less';
@import '~node_modules/ng-zorro-antd/alert/style/entry.less';
@import '~node_modules/ng-zorro-antd/space/style/entry.less';

However, when it comes to import style for segmented, it breaks

/* works */
@import '~node_modules/ng-zorro-antd/segmented/style/index.less';

/* not works */
@import '~node_modules/ng-zorro-antd/segmented/style/entry.less';

Issue Number: N/A

What is the new behavior?

Below code snippet used to import style for segmented should works

@import '~node_modules/ng-zorro-antd/segmented/style/entry.less';

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@zorro-bot
Copy link

zorro-bot bot commented Sep 3, 2022

This preview will be available after the AzureCI is passed.

@simplejason
Copy link
Member

please make sure all tests work as except :)

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #7624 (4f3bed0) into master (d14f20d) will not change coverage.
The diff coverage is n/a.

❗ Current head 4f3bed0 differs from pull request most recent head 5919314. Consider uploading reports for the commit 5919314 to get more accurate results

@@           Coverage Diff           @@
##           master    #7624   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files         502      502           
  Lines       16748    16748           
  Branches     2631     2631           
=======================================
  Hits        15413    15413           
  Misses       1065     1065           
  Partials      270      270           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@laggage laggage force-pushed the fix-no-import-in-entry-segmented branch from 4f3bed0 to 5919314 Compare September 26, 2022 02:59
@laggage
Copy link
Contributor Author

laggage commented Sep 26, 2022

Rebased onto master, now all tests have passed

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 1d6a646 into NG-ZORRO:master Oct 9, 2022
chenc041 pushed a commit to chenc041/ng-zorro-antd that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants